Fix Scala.js tests not running plus update SBT/Scala Version #2184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Scala.js tests were not running when using
docker-compose run --rm sbt sbt test
likely due to node changing the binary path of the installation which Scala.js couldn't detectSolution
Update the SBT docker image to the latest version gets the Scala tests running again. It seems like the upgrade of SBT has also fixed historical memory issues with SBT, i.e.
No longer seems to occur on my local machine
Notes
Since the SBT docker image was updated to the latest version, I also updated the corresponding Scala versions. I have also added the coursier directory to be cached so that every test invocation doesn't need to re-download dependencies.
Note that the PR will fail to build until #2183 is merged (and I rebase this PR)Checklist
README.md
if applicable[WIP]
to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormat
to make sure that the source files are formatted@getquill/maintainers