Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scala.js tests not running plus update SBT/Scala Version #2184

Merged
merged 1 commit into from Jul 4, 2021

Conversation

mdedetrich
Copy link
Collaborator

@mdedetrich mdedetrich commented Jul 3, 2021

Problem

The Scala.js tests were not running when using docker-compose run --rm sbt sbt test likely due to node changing the binary path of the installation which Scala.js couldn't detect

Solution

Update the SBT docker image to the latest version gets the Scala tests running again. It seems like the upgrade of SBT has also fixed historical memory issues with SBT, i.e.

[warn] In the last 9 seconds, 5.127 (60.2%) were spent in GC. [Heap: 0.37GB free of 1.45GB, max 1.45GB] Consider increasing the JVM heap using `-Xmx` or try a different collector, e.g. `-XX:+UseG1GC`, for better performance.
java.lang.OutOfMemoryError: Java heap space
[error] [launcher] error during sbt launcher: java.lang.OutOfMemoryError: Java heap space

No longer seems to occur on my local machine

Notes

Since the SBT docker image was updated to the latest version, I also updated the corresponding Scala versions. I have also added the coursier directory to be cached so that every test invocation doesn't need to re-download dependencies.

Note that the PR will fail to build until #2183 is merged (and I rebase this PR)

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@mdedetrich
Copy link
Collaborator Author

@deusaquilus I have just rebased off master which includes #2183 so the PR should be good to merge (the tests also passed earlier when you yourself pushed master into the branch)

@mdedetrich
Copy link
Collaborator Author

@deusaquilus All tests are passing

@mdedetrich mdedetrich mentioned this pull request Jul 4, 2021
5 tasks
@mdedetrich
Copy link
Collaborator Author

@deusaquilus I have bumped the SBT version again (a new version just came out yesterday) and rebased it again so its ready to merge.

@deusaquilus deusaquilus merged commit 3877b6e into zio:master Jul 4, 2021
@mdedetrich mdedetrich deleted the fix-scalasbt-nodejs-image branch July 4, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants