Use ZIO-Native Iterator chunking for JDBC result sets #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deusaquilus
force-pushed
the
zio_jdbc_native_streaming
branch
from
86db96a
to
c7cfac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ZIO
1.0.5did not have a native chunked stream, one needed to be implemented so that fetch-size of the JDBC result set would translate into correspondingly-sized chunks of the ZStream (when thecontext.streamfunction was called). Now since the is aZStream.fromIteratormethod takes a size-hint argument, we should just use that instead.