Merge pull request #515 from moyomot/fix/only_email_authentication

Fix: change wording on login screen "username or email" -> "email"
getredash · Jul 30, 2015 · 2eb171e · 2eb171e
2 parents fe1cc78 + 3753f58
commit 2eb171e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/rd_ui/app/login.html b/rd_ui/app/login.html
@@ -74,8 +74,8 @@
 
             <form role="form" method="post" name="login">
                 <div class="form-group">
-                    <label for="inputUsernameEmail">Username or email</label>
-                    <input type="text" class="form-control" id="inputUsernameEmail" name="username" value="{{username}}">
+                    <label for="inputEmail">Email</label>
+                    <input type="text" class="form-control" id="inputEmail" name="email" value="{{email}}">
                 </div>
                 <div class="form-group">
                     <!--<a class="pull-right" href="#">Forgot password?</a>-->

diff --git a/redash/controllers.py b/redash/controllers.py
@@ -80,15 +80,15 @@ def login():
 
     if request.method == 'POST':
         try:
-            user = models.User.get_by_email(request.form['username'])
+            user = models.User.get_by_email(request.form['email'])
             if user and user.verify_password(request.form['password']):
                 remember = ('remember' in request.form)
                 login_user(user, remember=remember)
                 return redirect(request.args.get('next') or '/')
             else:
-                flash("Wrong username or password.")
+                flash("Wrong email or password.")
         except models.User.DoesNotExist:
-            flash("Wrong username or password.")
+            flash("Wrong email or password.")
 
     return render_template("login.html",
                            name=settings.NAME,