-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Python 3 #4181
Comments
Related: #2891. |
We will probably need to update some dependencies (either versions or replace) as outlined in #2891. But as we will be carefully testing everything, it's worth bumping the versions of other dependencies like moving to Flask 1.0+. |
Hi, here is the summary of my progress on this issue for the week:
Currently the web app and the tasks work fine for me on Python 3. I have not encountered any error using the application locally, but I have only tested the Postgres and MySQL datasources. Feel free to give it a try if you want, the code is in the |
Thank you for the detailed update, @NicolasLM. 👍 |
Only a single test remains broken: Besides that I also stopped using the CSV |
I think you're right. I changed the test to use
I believe that without it trying to write unicode into CSV failed. The implementation of |
Hi, regarding the port of the code to Python 3:
I think that the code is ready for a review and thorough testing (specifically regarding data sources). Let me know if you want me to open a PR before the work on RQ is merged. |
This is exciting! :) When I was running the tests locally I noticed that there were many warnings. Most seemed to be deprecation warnings. Some of them were due to issues in our code and some were due to older dependencies using some other dependencies in a deprecated way (mostly SQLA uses). Considering we will put the system to a thorough testing due to the Python 3 migration, how about we upgrade our dependencies now that all tests are passing? You can open the PR regardless, but we do need to decide whether we want to:
@rauchy wdyt? |
Ok, let's aim to merge it soon then. If any problem arises when syncing the Python 3 brancn with these changes, will try to assist. |
I saw that the RQ branch was merged, so I rebased my work on master, fixed a few things and pushed a new branch |
@NicolasLM awesome, thank you! |
@NicolasLM super! Any thoughts on the dependencies update? We can do it in two steps:
And after that put the whole thing into rigorous testing. |
Sounds like a good plan. |
Let's do it :-) |
OMG! I stepped away for a bit and now this! 🎉 |
@NicolasLM i've just came across a little issue in python query runner. There are couple of py2 builtins (reduce, cmp, unicode) used here: redash/redash/query_runner/python.py Line 41 in 5cd6913
that breaks the process here: redash/redash/query_runner/python.py Line 239 in 5cd6913
would be great if you include this in v3 migration. |
The Python 3 migration is over. We been running this in production for the past month and overall things look stable. |
As Python 2 reaches EOL, we're planning to have the next release of Redash to support Python 3.
Because Python 2 reaches EOL and the fact we don't have capacity to support both versions, once we switch to Python 3 we will support Python 3 only.
The text was updated successfully, but these errors were encountered: