Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages with "resolve" don't redirect guests to the login page #4605

Closed
gabrieldutra opened this issue Feb 4, 2020 · 1 comment · Fixed by #4607
Closed

Pages with "resolve" don't redirect guests to the login page #4605

gabrieldutra opened this issue Feb 4, 2020 · 1 comment · Fixed by #4607

Comments

@gabrieldutra
Copy link
Member

gabrieldutra commented Feb 4, 2020

Issue Summary

Currently only the Query Pages use it.

Opening an issue more to discuss how to proceed, since there was discussion regarding not using 'resolve' in pages anymore, I think this is the way we'll go.

One thing to see is that without the "resolve", the Query Pages will now need a Loading State (or just have nothing rendered until finish with loading like the dashboard pages).

Steps to Reproduce

  1. Open any query page logged out (can just open in incognito), like this one
  2. Verify that the 404 page takes precedence and it does not redirect to the login page

resolve-issue

Technical details:

  • Redash Version: Latest
  • Browser/OS: *
  • How did you install Redash: *
@kravets-levko
Copy link
Collaborator

Good catch @gabrieldutra! Luckily, yesterday I already started working on removing resolve feature 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants