Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scientific Notation numbers are rendered as NaN values #4781

Open
jensenity opened this issue Apr 7, 2020 · 2 comments
Open

Scientific Notation numbers are rendered as NaN values #4781

jensenity opened this issue Apr 7, 2020 · 2 comments

Comments

@jensenity
Copy link

Issue Summary

A summary of the issue and the browser/OS environment in which it occurs.

Redash on browser. Using AWS Athena as our main data source, but decimal(38,0) value is not fully supported. Some works, but if the value is over a certain length, it returns NaN

Steps to Reproduce

-- Running it on AWS Athena & Redash shows different results
Athena
select 100000000000000000000000.00; --value shows 9.999999999999999E22

Redash
select 100000000000000000000000.00; --value shows NaN

Any other info e.g. Why do you consider this to be a bug? What did you expect to happen instead?
Posted a question on discussion redash page, and the team directed me here.
Link : Redash Discussion Post

Technical details:

  • Redash Version: Free Trial on Browser
  • Browser/OS: Google Chrome Version 80.0.3987.149
  • How did you install Redash: Did not install anything. Only using the browser
@susodapop
Copy link
Contributor

I was able to reproduce this on our demo instance.

@gabrieldutra
Copy link
Member

This is not isolated to Athena DS, but rather an issue with Scientific Notation (value is returned from backend as 1e+23) on the Library we currently use to format Numbers (Numeral.js) -> adamwdraper/Numeral-js#512.

I believe having the scientific notation is not a problem, so the real issue is not supporting it.

@gabrieldutra gabrieldutra changed the title Athena decimal value overflow error bug Scientific Notation numbers are rendered as NaN values Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants