Confusing comment in a db migration

[eugene-nikolaev]

Issue Summary

Issue in the code comment (opposite meaning).

Commit title says:

Give query case sensitive treatment in query hash (https://github.com/getredash/redash/pull/4254)
Generating the query hash from the query text with no lowercasing of the query text
allows case-sensitive parameter values in the dashboard to have different cache entries.

But in the migration:

Make case insensitive hash of query text

Which have the opposite meaning.

Should be written as:

Make case sensitive hash of query text

Steps to Reproduce

Not applicable

Technical details:

No matter

[justinclift]

Good point. Possibly a typo in one of the pieces. Let's ask.

@osule What are your thoughts on this? 😄

[osule]

@eugene-nikolaev It should be corrected to case-sensitive hash of query text

[justinclift]

Anyone want to create a PR for that? It'll be merged fairly quickly. 😄

[eugene-nikolaev]

BTW had issues which maybe caused with this migration on existing 10.1 instance.
Query results were not cached at all.
No time at the moment to dig deeper and make a proper report, I just reverted everything.

Also reverting from current master to 10.1 back required some hacking as some strings did not fit in that limit=320.

redash/migrations/versions/fd4fc850d7ea_.py

Line 44 in ea4ee7c

op.add_column("users", sa.Column("profile_image_url", db.String(320), nullable=True))

Hopefully I'll be able to tinker with it and create proper issues/PRs.

[justinclift]

Ouch. Yeah, our current CI tests are good for some stuff. But we really need to also set up some more in-depth automatic testing with actual proper test data and have it run "like" it would in production.

I have some ideas, but it's not something I'll get to this week personally. Fixing more immediate stuff first. 😄

---

Btw, when you do do want to tinker with stuff then we've recently been working on decent instructions for setting up your local dev environment:

https://github.com/getredash/redash/wiki/Local-development-setup

The stuff on the wiki is known to work, whereas the "developer setup guides" (currently) on the official Redash knowledge base are still pretty busted. We'll need to migrate the wiki content there at some point, but it's not a high priority (yet). 😄