New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve chart editor UI/UX #671

Closed

alonho opened this issue Nov 24, 2015 · 0 comments

Contributor

alonho commented Nov 24, 2015

Here's a glimpse:

Things I did:

Added ui-select widgets for selecting x/y/dimension.
Refactored the hell out of the chart-editor directive (it now has an isolated scope).
Changed some names (column chart -> bar chart) while keeping the model backward compatible.
Add a name label to all axes.

Things I'm unsure of:

When a query returns with other columns that these defined in the widgets they are cleared. Would it be annoying for the user? (imagine a situation where you change the query and it returns 0 rows, it then clears all the widgets).
I changed stacking types names to: disabled, enabled and relative. Not sure if it's better than before.
The layout of the widgets isn't perfect (the space to the right of the "Y Columns" is bothering my OCD).

alonho added a commit to alonho/redash that referenced this issue


          getredash#671: Improve chart editor UI/UX

3b24f56

arikfr closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment