Fixes #121: redesign query page (have separate page for editing and viewing) #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -111,6 +111,7 @@ | |||
| <!-- build:js({.tmp,app}) /scripts/scripts.js --> | |||
| <script src="/scripts/app.js"></script> | |||
| <script src="/scripts/controllers.js"></script> | |||
| <script src="/scripts/controllers/QueryView.js"></script> | |||
There was a problem hiding this comment.
Filename should be query_view.js.
|
A live document of issues we find: https://hackpad.com/Issues-with-126-query-view-U9hbK9bKbyF |
…oller when resolved
* source as link instead of button * fix source link when url has a hash * new query uses the new layout * rename url /src => /source... * when deleting a visualization update the hash * don't submit title/description if it hasn't changed * mobile: fix description field wrapping
arikfr
added a commit
that referenced
this pull request
Mar 11, 2014
Fixes #121: redesign query page (have separate page for editing and viewing)
christophervalles
pushed a commit
to hailocab/redash
that referenced
this pull request
May 8, 2014
Fixes getredash#121: redesign query page (have separate page for editing and viewing)
washort
pushed a commit
to washort/redash
that referenced
this pull request
Jul 25, 2017
M6 replay non athena then athena
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new page is available at /queries/view/[queryId]
QueryViewCtrlis a clonedQueryFiddleCtrlwith some fixes