Change: switch from flask_script to click, add CLI unit tests and upgrade Flask version #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Dec 6, 2016
| @@ -2,62 +2,75 @@ | |||
| """ | |||
| CLI to manage redash. | |||
| """ | |||
| import code | |||
There was a problem hiding this comment.
Oops, that's when I was trying to add a shell command and not noticing flask already provided one.
| self.assertEqual(result.exit_code, 1) | ||
| self.assertIn('not found', result.output) | ||
|
|
||
| ## XXX figure out how to capture celery tasks kicked off in a subprocess??? |
There was a problem hiding this comment.
I usually mock the method that submits the task to verify it was called.
There was a problem hiding this comment.
Yes, the problem is that the click testing stuff runs the code in a subprocess, so you can't directly mock. I think I might split the actual work into a separate function and test it separately.
There was a problem hiding this comment.
I was wrong, it just captures stdio. Test fixed.
arikfr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides basic test coverage for the CLI commands and replaces
flask_script.Closes #1112.