Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker file ownership issues: #1656

Merged
merged 1 commit into from
Mar 7, 2017
Merged

Fix Docker file ownership issues: #1656

merged 1 commit into from
Mar 7, 2017

Conversation

arikfr
Copy link
Member

@arikfr arikfr commented Mar 7, 2017

  1. Simplify user creation to create a non system user (so the uid will usually
    match the host user).
  2. Set the user to redash & remove the need to change user in docker entrypoint.

1. Simplify user creation to create a non system user (so the uid will usually
   match the host user).
2. Set the user to redash & remove the need to change user in docker entrypoint.
@arikfr arikfr merged commit 3f8e32c into master Mar 7, 2017
@arikfr arikfr deleted the docker branch March 7, 2017 09:40
@44px
Copy link
Contributor

44px commented Mar 16, 2017

@arikfr, can these changes broke redash_worker container?

After pulling latest changes I noticed that queries stuck in queue.

docker-compose ps shows this:

redash_worker_1     /app/bin/docker-entrypoint ...   Exit 1

redash_worker_1 shuts down soon after start (I checked multiple times)

docker logs redash_worker_1 ends with:

worker: Warm shutdown (MainProcess)
[2017-03-16 21:04:13,956: INFO/MainProcess] beat: Shutting down...
Starting scheduler and 2 workers for queues: queries,scheduled_queries,celery...
Running a worker with superuser privileges when the
worker accepts messages serialized with pickle is a very bad idea!

If you really want to continue then you have to set the C_FORCE_ROOT
environment variable (but please think about this before you do).

User information: uid=0 euid=0 gid=0 egid=0

I restored sudo -E -u redash in bin/docker-entrypoint and queries queue works as before now.

@arikfr
Copy link
Member Author

arikfr commented Mar 20, 2017

You need to rebuild the container (docker-compose rm server / docker-compose rm worker and then create or up).

@44px
Copy link
Contributor

44px commented Mar 21, 2017

Thanks, it works!
A bit strange - I tried docker-compose rm and then docker-compose up previously, but it didn't help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants