Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Trimmed ; from query as it causes trouble when using pyhive #1662

Closed
wants to merge 1 commit into from

Conversation

benmagro
Copy link

@benmagro benmagro commented Mar 9, 2017

When using the pyhive connector, queries fail if they have a colon at the end. This can be pretty annoying.

Not sure if this is the best way to fix the problem. Happy to take feedback on the PR.

Thanks

@benmagro benmagro changed the title Trimmed ; from query as it causes trouble when using pyhive Add: Trimmed ; from query as it causes trouble when using pyhive Mar 10, 2017
Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is Hive specific, let's move this logic to the Hive query runner.

@arikfr
Copy link
Member

arikfr commented Apr 30, 2017

@benmagro Ping?

@benmagro
Copy link
Author

benmagro commented May 1, 2017

On it. I'll move. Just been flat out :-)

@arikfr
Copy link
Member

arikfr commented Sep 13, 2017

Please reopen when updated. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants