Change: add support for filtered data in Pivot table visualization #1666
Conversation
| const rowObj = {}; | ||
| columns.forEach((col) => { | ||
| const colName = getColumnCleanName(col.name); | ||
| const value = formatValue($filter, clientConfig, row[col.name], col.type); |
There was a problem hiding this comment.
Two things that come to mind here:
- Are we sure that converting numbers into strings will behave properly with PivotTable?
- For dates, shouldn't we use some standard like (YYYY-MM-DD) regardless of configuration to solve Time series in pivot tables appear to be ordered by first letter of month - rather than by date #216?
There was a problem hiding this comment.
-
Comment 2
I am thinking of adding a Sorting option to pivottable editor. Because passing a sort-friendly format will work for numerical dates, but it doesn't help for Monday/Tuesday/..., Mon/Tue/..., January/February/..., Jan/Feb/..., etc.
If we passREDAH_DATE_FORMATto pivot, the problem below will go away because the dates won't be in ISO format,
and letting people define custom sorters will take care of the first comment of #216.
- Comment 1
I have to look into it a bit more for part 1 of your comment.
There was a problem hiding this comment.
They have a way to pass a sort function?
Anyway, how about we change this pull request to only handle the filters part and leave the formatting to another pull request?
There was a problem hiding this comment.
Yes they do. Example is here.
I have to come up with how to let people define it in pivottable editor, but currently have no idea.
I'm perfectly fine with dividing this PR into two, and making this only about the filters.
I assume what you mean is just replacing .getRawData() to .getData()?
There was a problem hiding this comment.
I have to come up with how to let people define it in pivottable editor, but currently have no idea.
The user shouldn't have to define them. We should have default ones for the types we have (dates, numbers, etc - where needed).
deecay
changed the title
|
This PR has been changed and now it is about fixing pivottable of filtered data. Formatting part will be addressed in a separate PR. |
arikfr
changed the title
This PR changes how the
datafed to pivottable visualization is prepared, and makes pivottable show filtered and formatted data just as you can see in Table visualization.I have noticed that pivottable visualization:
::filterannotation appears as part of pivottable attribute name and does not get removedREDASH_DATE_FORMATThis PR addresses all three points.