Textbox editing fix #1896
Merged
Textbox editing fix #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combines mozilla/redash PR’s 86 and 95. There was a bug that saved textbox content on a dashboard when you tried to close without saving. This fixes it.
arikfr
reviewed
Aug 6, 2017
| @@ -8,7 +8,7 @@ const EditTextBoxComponent = { | |||
| close: '&', | |||
| dismiss: '&', | |||
| }, | |||
| controller(toastr) { | |||
| controller($rootScope, $location, $http, toastr) { | |||
There was a problem hiding this comment.
Why the extra injects are needed?
There was a problem hiding this comment.
They aren't. Good eye, thanks.
| }, | ||
| }; | ||
|
|
||
| function DashboardWidgetCtrl($location, $uibModal, $window, Events, currentUser) { | ||
| this.canViewQuery = currentUser.hasPermission('view_query'); | ||
|
|
||
| this.editTextBox = () => { | ||
| this.widget.existing_text = this.widget.text; |
There was a problem hiding this comment.
I think it will be better to keep this logic in the component. So the component will make a copy of the original value and restore to it when closed instead of saved.
Another option is to use a different object as the ng-model of the <textarea> and only on save assign it to the widget. This way no extra logic is needed on close and you can bring back keyboard support.
|
@arikfr Updated. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines mozilla/redash PR’s 86 and 95.
There was a bug that saved textbox content on a dashboard when you
tried to close without saving. This fixes it.