Make /opt/redash directory if it's not exist. #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Oct 22, 2017
setup/ubuntu/bootstrap.sh
Outdated
| @@ -50,7 +50,7 @@ install_system_packages() { | |||
| } | |||
|
|
|||
| create_directories() { | |||
| mkdir /opt/redash | |||
| mkdir -p /opt/redash | |||
There was a problem hiding this comment.
Did it ever happen to you that /opt wasn't there? Otherwise why do we need this?
There was a problem hiding this comment.
@arikfr
When this script was terminated abnormally after /opt/redash directory was made, "/opt/redash already exists." error occurred everytime with this mkdir command.
P option ignore even if /opt/redash exists.
There was a problem hiding this comment.
In general this script is not idempotent and I would be careful to run it again "blindly".
There was a problem hiding this comment.
But it's safe enough to make this change, so merging. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change make this setup script easy to retry.