Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design/refinements 2 #2113

Merged
merged 45 commits into from Dec 5, 2017
Merged

Design/refinements 2 #2113

merged 45 commits into from Dec 5, 2017

Conversation

kocsmy
Copy link
Collaborator

@kocsmy kocsmy commented Dec 2, 2017

There are a couple of design improvements in this PR:

Tables:

  • headers are now Title Case instead of UPPERCASE
  • numerous padding and margin improvements
  • adjusted table header colors

Query screen:

  • Rearranged query editor control buttons: Execute query moved to the right, Fork moved under ...
  • Show/Hide Source button now is better connected to its area
  • Query editor auto-suggest dropdown now highlights nicer (than the previous bulky dropshadow)
  • Numerous spacing fixes so it feels more consistent across the product

STYLING-README:

  • Added a basic styling readme for contributors so we can try to be a bit more consistent and write better quality code (and avoid inline css) - will add more details to this

General styling:

  • Bug fix: fullscreen not hiding navigation now hides navigation again
  • Now, we're using system-fonts as default and Roboto has been removed: font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif !important;
  • Pagination is now rectangular instead of circular to better align with our styling direction
  • Public Dashboards are now navigation free for better data consuming experience. Powered by Redash also added to the footer.
  • Edit Layout now disables Query Headers to link to its query page and replaced with cursor: move to indicate that you can move the widgets in edit mode.
  • Line height fixes so longer dashboard and query names will look better when they break to multiline.

# Conflicts:
#	client/app/pages/dashboards/public-dashboard-page.html
# Conflicts:
#	client/app/components/filters.html
@kocsmy
Copy link
Collaborator Author

kocsmy commented Dec 2, 2017

Query Before:
query-old

Query After:
query-new

@arikfr
Copy link
Member

arikfr commented Dec 3, 2017

  1. Looks a bit strange that the ... button is in the middle, no?
  2. The "Data Source" label got truncated to "Data", not sure if it's intentional. Maybe the icon is enough?
  3. "headers are now Title Case instead of UPPERCASE" -> we can skip this (apply on transformation).
  4. How does the results page look like?

@kocsmy
Copy link
Collaborator Author

kocsmy commented Dec 3, 2017

  1. I don't think it's strange (especially because the Execute button is more prominent and btn-primary).
  2. Yes, I made it shorter but we can even use the icon only.
  3. Ok.
  4. Which one is the result page?

@kyoshidajp
Copy link
Member

@kocsmy An error Error: could not determine PostgreSQL version from '10.0' in CircleCI has already fixed on master branch by #2111. If you rebase master, then the error would not be reproduced ☀️

# Conflicts:
#	client/app/components/dynamic-table/dynamic-table.html
#	client/app/pages/queries/query.html
@kocsmy
Copy link
Collaborator Author

kocsmy commented Dec 5, 2017

Further improvements added, see screenshots:
screenshot 2017-12-05 13 05 48

screenshot 2017-12-05 13 05 25

@arikfr arikfr merged commit 004f550 into getredash:master Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants