Redesign of all pages that are rendered by backend code #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
requested changes
Feb 15, 2018
| @@ -1,8 +1,16 @@ | |||
| {% extends "layouts/signed_out.html" %} | |||
|
|
|||
| {% block title %}Error :-({% endblock %} | |||
There was a problem hiding this comment.
I think we can remove this now. The alert icon serves a similar purpose.
redash/templates/invite.html
Outdated
| <div class="fixed-width-page"> | ||
| <div class="bg-white tiled"> | ||
| <div class="m-b-default"> | ||
| {% if google_auth_url %} |
There was a problem hiding this comment.
Need to support SAML and the other providers here too (although SAML is the important one). How about, have two variations of the text:
Has SSO provider (Google, SAML, LDAP, etc) available: "To create your account, please choose a password or login with your SSO provider."
No SSO provider: "To create your account, please choose a password."
Then show the different login buttons as we do on the login page.
|
@arikfr Updated this PR. Hope I didn't miss anything when adding SSO login buttons to Invite user page but please review it. Error page: Invite user page: |
arikfr
approved these changes
Feb 18, 2018
|
💃 |
dairyo
pushed a commit
to KiiCorp/redash
that referenced
this pull request
Mar 1, 2019
…ages-redesign Redesign of all pages that are rendered by backend code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Login page:
Forgot password page:
Password reset page:
Invite user page:
Error page:
Setup page:
