Refactored dashboard drag/resize testing #3726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranbena
force-pushed
the
drag-resize-tests
branch
from
71f371e
to
1a0674e
Compare
10 tasks
gabrieldutra
approved these changes
Apr 20, 2019
| expect(delta.height).to.eq(0); | ||
| }); | ||
| resizeBy(cy.get('@textboxEl'), 0, 10) | ||
| .then(() => cy.get('@textboxEl')) |
There was a problem hiding this comment.
I think this being necessary is a sign that passing a cy.get() as an argument is an anti-pattern (similar to this one). We should rather use it as a Cypress command or pass something else as argument.
For now I think it's ok to leave as is, but let's keep in mind this to when we discover a better way to treat those helper commands.
There was a problem hiding this comment.
I worked on making dragBy and resizeBy into commands but it didn't go smooth so I'm leaving as is to keep moving forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As preparation for #3722 I leveraged the retrying nature of
should()to "wait" till drag/resize animations are over, therefore making these methods much simpler and more generic.This is a no brainer - all test pass and that's all that matters!
@gabrieldutra I couldn't make
increase(func).by(value)work, so instead I just assert the end value (width/height/top/left). It's less pretty but works just as well.