Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it obvious that the query link is clickable. #433

Merged
merged 1 commit into from May 17, 2015

Conversation

stanhu
Copy link
Contributor

@stanhu stanhu commented May 15, 2015

Underline when hovering over the link and add glyphicon

Before:

image

After:

image

@stanhu
Copy link
Contributor Author

stanhu commented May 15, 2015

Hmm, I think I need to take into account the view_query and edit_query permissions. Looks like it works fine. Can you verify?

@arikfr
Copy link
Member

arikfr commented May 17, 2015

The anchor feels a bit too "bold", how about we wrap it with <small>? The result will be:

image

@stanhu
Copy link
Contributor Author

stanhu commented May 17, 2015

Great idea. Updated.

@arikfr arikfr changed the title Make it obvious that the query link is clickable Make it obvious that the query link is clickable. May 17, 2015
arikfr added a commit that referenced this pull request May 17, 2015
Make it obvious that the query link is clickable.
@arikfr arikfr merged commit 6312f87 into getredash:master May 17, 2015
@arikfr
Copy link
Member

arikfr commented May 17, 2015

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants