Fix: when the server has non UTC timezone, timestamps were wrong #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -272,7 +271,7 @@ def execute_query(self, query, data_source_id, metadata): | |||
| redis_connection.delete(QueryTask._job_lock_id(query_hash, data_source.id)) | |||
|
|
|||
| if not error: | |||
| query_result = models.QueryResult.store_result(data_source.id, query_hash, query, data, run_time, datetime.datetime.utcnow()) | |||
| query_result = models.QueryResult.store_result(data_source.id, query_hash, query, data, run_time, utils.utcnow()) | |||
There was a problem hiding this comment.
@runa this is the actual fix for the timezone issue. Until I get to properly test this and merge it in, if you want you can patch your install by editing /opt/redash/current/redash/tasks.py and changing on this line datetime.datetime.utcnow() to: datetime.datetime.now(pytz.utc) and adding import pytz at the top of the file.
arikfr
added a commit
that referenced
this pull request
Jun 7, 2015
Fix: when the server has non UTC timezone, timestamps were wrong
dairyo
pushed a commit
to KiiCorp/redash
that referenced
this pull request
Mar 1, 2019
Fix: when the server has non UTC timezone, timestamps were wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.