bugfix: fail to parse elasticsearch mappings #5123
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Elasticsearch query_runner may raise TypeError when
dynamic
setting presents.e.g. for the following mapping:
date_detection
andnumeric_detection
have bool values.BaseElasticSearch._get_query_mappings
will raise "TypeError: argument of type 'bool' is not iterable" and fails to return any results for queries.Check Elasticsearch docs for more details.
This PR add an additional condition check to ignore such fields.