Heatmap controls #5263
Heatmap controls #5263
Conversation
|
Nice features! I'll wait your considerations on the previous comment and then merge. If you're interested, take a look at this, could be a cool addition! |
There was a problem hiding this comment.
Just noticed that for some reason updating the zMin by itself doesn't trigger UI responsiveness. @kravets-levko do you know why? zMax works as expected
|
@deecay , thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts? We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that. |
|
Looking over this PR, it seems like the files it was created for are now using TypeScript (eg It doesn't look too complicated though, at least for someone already familiar with TypeScript (not me at this stage). 😄 |
deecay
force-pushed
the
heatmap-controls
branch
from
494022d
to
06dfa99
Compare
Codecov Report
@@ Coverage Diff @@
## master #5263 +/- ##
==========================================
+ Coverage 61.89% 61.90% +0.01%
==========================================
Files 158 158
Lines 12966 12966
Branches 1773 1773
==========================================
+ Hits 8025 8027 +2
+ Misses 4666 4664 -2
Partials 275 275 |
justinclift
requested review from
eradman
and removed request for
gabrieldutra
|
@justinclift |
| @@ -33,6 +33,10 @@ function prepareSeries(series: any, options: any, additionalOptions: any) { | |||
| type: "heatmap", | |||
| name: "", | |||
| colorscale: colorScheme, | |||
| xgap: (options.heatmapSpacing || 0) * 0.2, | |||
| ygap: (options.heatmapSpacing || 0) * 0.2, | |||
There was a problem hiding this comment.
We do not need to divide the user input. If the user wants a very faint line they can input 0.2
There was a problem hiding this comment.
Done in [fcf6e1b].
| @@ -3,6 +3,8 @@ import React, { useMemo } from "react"; | |||
| import { Section, Select, Checkbox, InputNumber, ContextHelp, Input } from "@/components/visualizations/editor"; | |||
| import { UpdateOptionsStrategy } from "@/components/visualizations/editor/createTabbedEditor"; | |||
| import { EditorPropTypes } from "@/visualizations/prop-types"; | |||
| import * as Grid from "antd/lib/grid"; | |||
There was a problem hiding this comment.
Should we avoid using import *? It would be better to see the module properties this line is intended to import
|
I think this is good to go |
What type of PR is this? (check all applicable)
Description
Adding more control to heatmap. Brick spacingand zRange (zmin and zmax).
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)