Feature: alert rearm setting which allows periodic resending of alert messages. #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| logger.info("Alert %d new state: %s", alert.id, new_state) | ||
| old_state = alert.state | ||
| alert.update_instance(state=new_state) | ||
| alert.update_instance(state=new_state, last_triggered_at=datetime.datetime.now()) |
There was a problem hiding this comment.
I think that if you use the utcnow function from redash.utils module here and on line 246, you won't need to replace the timezone.
There was a problem hiding this comment.
@nielsdraaisma can you make this change?
arikfr
changed the title
|
@arikfr thanks for the PR, sorry I just noticed it. @nielsdraaisma is busy with his new role. |
…chat Feature: send alert notifications to HipChat or web hook
|
@blu35ky thanks! do you mind also rebasing it w/ latest master, so I can easily merge it? |
|
@arikfr np, done. 👍 |
arikfr
added a commit
that referenced
this pull request
Dec 10, 2015
Feature: alert rearm setting which allows periodic resending of alert messages.
|
Merged now. Apologies that it took so long. |
dairyo
pushed a commit
to KiiCorp/redash
that referenced
this pull request
Mar 1, 2019
Feature: alert rearm setting which allows periodic resending of alert messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a setting which matches against a rearm timer after query execution, this allows users to receive daily emails for alerts that are trigger over a longer period of time.