Fixed error serialization #6937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6937 +/- ##
==========================================
+ Coverage 63.80% 63.83% +0.03%
==========================================
Files 161 161
Lines 13087 13094 +7
Branches 1812 1814 +2
==========================================
+ Hits 8350 8359 +9
+ Misses 4434 4432 -2
Partials 303 303
|
AndrewChubatiuk
force-pushed
the
fixed-error-serialization
branch
from
6d0075e
to
9d4b241
Compare
|
This change seems to resolve the problem. As codecov is highlighting, we should add some tests for this updated code path. |
AndrewChubatiuk
force-pushed
the
fixed-error-serialization
branch
from
9d4b241
to
121f2ef
Compare
added tests |
eradman
approved these changes
May 2, 2024
eradman
force-pushed
the
fixed-error-serialization
branch
from
21ff4b7
to
26cc1b9
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Fixes #6936
Description
How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)