Add gas limit and gas estimation in getFees()

getsafle · Nov 30, 2023 · dfcf8ea · dfcf8ea
1 parent 91e2070
commit dfcf8ea
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -40,4 +40,9 @@
 
 ### 1.2.3 (2023-11-27)
 
-- Updated node version to 18x
+- Updated node version to 18x
+
+### 1.2.4 (2023-11-30)
+
+- Add gas limit and gas estimation in getFees()
+- updated tests for getFees() update
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@getsafle/vault-bsc-controller",
-  "version": "1.2.3",
+  "version": "1.2.4",
   "description": "",
   "engines": {
     "node": ">= 10"

diff --git a/src/index.js b/src/index.js
@@ -521,10 +521,10 @@ class KeyringController extends EventEmitter {
     }
 
     async getFees(bscTx, web3) {
-        const { from, to, value, data, gasLimit } = bscTx
-        const estimate = gasLimit ? gasLimit : await web3.eth.estimateGas({ to, from, value, data })
+        const { from, to, value, data } = bscTx
+        const gasLimit = await web3.eth.estimateGas({ to, from, value, data })
         const gasPrice = await web3.eth.getGasPrice();
-        return { transactionFees: estimate * gasPrice }
+        return { gasLimit: gasLimit, gasPrice: gasPrice}
     }
 }