Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce internal commands to manage execution state #112

Merged
merged 31 commits into from
Jun 13, 2024
Merged

Conversation

joshi4
Copy link
Contributor

@joshi4 joshi4 commented Jun 13, 2024

  • cmd/internal: setup internal cmds
  • parse params
  • server/client: Create client for any socket path
  • server: DRY cleanup socket committed
  • client: Add a shutdown interface
  • server/run: Add a run server
  • savvy.zsh: only use zle to trigger runner
  • server/client: SendShutdown returns an err
  • server/run: Update state based on commands
  • server/run: Add client for run server
  • cmd/run: use runServer to coordinate state
  • server/run: disambiguate client struct from pkg
  • cmd/internal: impl current and next
  • change return data for next and current
  • cmd/history: handle err starting record server
  • run: start server
  • server/run: read json messages instead of waiting for client to close the conn
  • close client conn when done
  • savvy.zsh: use internal commands to run runbooks
  • cmd/next: return immediately if no prev command
  • server/run: return val using json encoder
  • server/run: allow idx == len(commands)
  • debug: savvy.zsh display next
  • add tests
  • setup/savvy.zsh: use 0 based arrays everywhere except when displaying step count
  • internal/next: return 0 based array idx
  • server/run: rm debug logs
  • setup/savvy.zsh: cleanup debug logs
  • server/run: Add note about why the run server is single threaded
  • cmd/setup/bash-preexec.sh: impl run hooks with savvy internal cmds
  • cmd/write: dracula shows better on light terminals

joshi4 added 30 commits June 10, 2024 12:15
We are adding a new server type called run to manage the state for
running runbooks.
@joshi4 joshi4 merged commit 46547ce into main Jun 13, 2024
1 check passed
@joshi4 joshi4 deleted the sj/internal-cmd branch June 13, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant