Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regressions #16

Merged
merged 4 commits into from
May 12, 2023
Merged

Fix regressions #16

merged 4 commits into from
May 12, 2023

Conversation

chadwhitacre
Copy link
Member

@chadwhitacre chadwhitacre commented May 12, 2023 •
edited
Loading

  • yarn dist wasn't working because the "main" in package.json was wrong
  • git ls-files comprehension was choking on empty lines
  • ref wasn't specified correctly in the GitHub API calls
  • don't need to explicitly base64-encode after all
  • move gitOutput debugging earlier so we see it in the case of an early return

@chadwhitacre chadwhitacre changed the title Fix yarn dist Fix regressions, add option to fail on empty May 12, 2023
@chadwhitacre chadwhitacre marked this pull request as draft May 12, 2023 19:37
@chadwhitacre chadwhitacre force-pushed the cwlw/fix-dist branch 2 times, most recently from 29311aa to 2e028bb Compare May 12, 2023 19:46
@chadwhitacre chadwhitacre changed the title Fix regressions, add option to fail on empty Fix regressions May 12, 2023
@chadwhitacre chadwhitacre force-pushed the cwlw/fix-dist branch 3 times, most recently from 82bc771 to fb8a80a Compare May 12, 2023 19:57
@chadwhitacre chadwhitacre marked this pull request as ready for review May 12, 2023 20:01
@chadwhitacre chadwhitacre mentioned this pull request May 12, 2023
Closed
@chadwhitacre
Copy link
Member Author

Closes #1.

mattgauntseo-sentry
mattgauntseo-sentry reviewed May 12, 2023
View reviewed changes
package.json Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
@chadwhitacre chadwhitacre force-pushed the cwlw/fix-dist branch 2 times, most recently from 4dd8f75 to 4178ae7 Compare May 12, 2023 20:25
@chadwhitacre chadwhitacre merged commit d83a7e6 into main May 12, 2023
2 checks passed
@chadwhitacre chadwhitacre deleted the cwlw/fix-dist branch May 12, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgauntseo-sentry mattgauntseo-sentry mattgauntseo-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chadwhitacre @mattgauntseo-sentry