Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Avoid spinning on MessageRejected #253

Merged
merged 2 commits into from
Jun 13, 2023
Merged

feat: Avoid spinning on MessageRejected #253

merged 2 commits into from
Jun 13, 2023

Conversation

lynnagara
Copy link
Member

@lynnagara lynnagara requested a review from a team as a code owner June 13, 2023 01:08
untitaker
untitaker approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you know, i was adamant that we punt on this issue and later solve it "properly" somehow in arroyo, but this is probably good enough. and honestly i hadn't considered it that we just merge the same hack from consumers into arroyo

@lynnagara lynnagara merged commit 6d13062 into main Jun 13, 2023
8 checks passed
@lynnagara lynnagara deleted the avoid-spin-message-rejected branch June 13, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lynnagara @untitaker