Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add optional received_p99 timestamp to commit log #295

Merged
merged 3 commits into from
Oct 18, 2023

Commits on Oct 15, 2023

  1. feat: Add optional received_p99 timestamp to commit log

    The value from the received field can be used in the future for
    subscription scheduling if this is provided. This is better than
    the `orig_message_ts` field as `received` is assigned at the very
    start of the pipeline when Sentry receives the event (as opposed to
    when Snuba gets the event). Switching to this field means any
    delays in ingestion will be properly accounted for when determining
    the window on which to schedule subscriptions.
    
    This PR also:
    - deprecates the legacy decoder since we have fully switched over to the new format
    - switches orig_message_ts from datetime to float. Converting between
    the two in encode/decode is pointless, and it introduces the possibility of
    timezone issues. Simpler to just keep it a unix timestamp everywhere.
    lynnagara committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    0ddc8f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. fix test

    lynnagara committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    4a498f1 View commit details
    Browse the repository at this point in the history
  2. update another test

    lynnagara committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    8e10c87 View commit details
    Browse the repository at this point in the history