fix: Cleanup backpressure state between assignments #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for inc-552 It caused a bug where a message could be submitted to the processing strategy twice immediately after assignment if there was backpressure before the rebalance.
john-z-yang
approved these changes
Nov 6, 2023
untitaker
added a commit
to getsentry/snuba
that referenced
this pull request
Nov 17, 2023
This is a port of getsentry/arroyo#299 SNS-2517
kokizzu
pushed a commit
to kokizzu/snuba
that referenced
this pull request
Nov 24, 2023
…y#5055) This is a port of getsentry/arroyo#299 SNS-2517
untitaker
added a commit
that referenced
this pull request
Jan 17, 2024
This is a port of #299 SNS-2517
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for inc-552
It caused a bug where a message could be submitted to the processing strategy twice immediately after assignment if there was backpressure before the rebalance.