fix: Default input block size should be larger #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were under the assumption that we can pick an arbitrarily low value here since it will be automatically resized. However, in the case where a single message is larger than the block size, the consumer can still crash. This is too hard to fix right now and not worth it, so hardcode it to 16M (which is more than the max Kafka message size), and hope it never happens again. The original purpose of dynamically resizing input blocks was to make performance tuning simpler, and IMO we still have achieved that.
lynnagara
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were under the assumption that we can pick an arbitrarily low value
here since it will be automatically resized. However, in the case where
a single message is larger than the block size, the consumer can still
crash.
This is too hard to fix right now and not worth it, so hardcode it to
16M (which is more than the max Kafka message size), and hope it never
happens again.
The original purpose of dynamically resizing input blocks was to make
performance tuning simpler, and IMO we still have achieved that.