feat: Enable automatic latency recording for consumers #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal of this change is to record a common latency metric for all consumers that use Arroyo. The new metric is called `arroyo.consumer.latency` -- it represents the time in seconds from when the message was initially produced (broker timestamp) to when the consumer successfully committed the offset for a message. Note that if a consumer is doing either manual batching (not using Arroyo's built in Reduce/Batch) or manual committing of offsets (not using Arroyo's CommitOffsets strategy), then the metric will not be recorded automatically. Closes #307
untitaker
approved these changes
Nov 22, 2023
lynnagara
added a commit
to getsentry/sentry
that referenced
this pull request
Nov 30, 2023
Since getsentry/arroyo#308 Arroyo's CommitOffsets strategy records consumer latency automatically for consumers immediately prior to committing offsets.
lynnagara
added a commit
to getsentry/sentry
that referenced
this pull request
Dec 1, 2023
Since getsentry/arroyo#308 Arroyo's CommitOffsets strategy records consumer latency automatically for consumers immediately prior to committing offsets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this change is to record a common latency metric for all consumers that use Arroyo.
The new metric is called
arroyo.consumer.latency-- it represents the time in seconds from when the message was initially produced (broker timestamp) to when the consumer successfully committed the offset for a message.Note that if a consumer is doing either manual batching (not using Arroyo's built in Reduce/Batch) or manual committing of offsets (not using Arroyo's CommitOffsets strategy), then the metric will not be recorded automatically.
Closes #307