feat: Reusable multiprocessing pool #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Sentry Issue ReportYou modified these files in this pull request and we noticed these issues associated with them. 📄 arroyo/processing/strategies/run_task_with_multiprocessing.py
Did you find this useful? React with a 👍 or 👎 or let us know in #proj-github-pr-comments |
lynnagara
changed the title
untitaker
approved these changes
Dec 5, 2023
lynnagara
added a commit
to getsentry/sentry
that referenced
this pull request
Dec 6, 2023
Companion to getsentry/arroyo#311 to demonstrate how it could work with the unified consumer / Arroyo wrappers in Sentry
untitaker
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RunTaskWithMultiprocessingstrategy now takes aMultiprocessingPoolas an argument. The user can safely reuse the multiprocessing pool between rebalances. Recreating the pool each time is still also possible and would match today's behavior.