New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Combine DlqLimitState methods #312

Merged

loewenheim merged 1 commit into main from ref/dlq-limit-state

Dec 6, 2023

Contributor

loewenheim commented Dec 6, 2023

This aligns DlqLimitState with the Rust implementation in getsentry/snuba#5156. To wit:

update_invalid_value and should_accept are combined into record_invalid_message, since they're never called independently.
We insert some default data if we've never received an invalid message on a partition.


          ref: Combine DlqLimitState methods

c891148

loewenheim requested a review from a team as a code owner

December 6, 2023 17:13

loewenheim self-assigned this

lynnagara approved these changes

View reviewed changes

Member

lynnagara left a comment

💯

loewenheim merged commit a1cca96 into main

8 checks passed

loewenheim deleted the ref/dlq-limit-state branch

December 6, 2023 19:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment