ref(metrics): Add pause/resume counters [INC-626] #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the linked incident we think that the ingest consumer paused/resumed in very quick succession. We currently don't have any metrics for that.
jjbayer
approved these changes
Feb 8, 2024
untitaker
commented
Feb 8, 2024
| @@ -150,7 +150,9 @@ def test_stream_processor_lifecycle() -> None: | |||
| (Timing, "arroyo.consumer.shutdown.time"), | |||
| (Timing, "arroyo.consumer.callback.time"), | |||
| (Timing, "arroyo.consumer.poll.time"), | |||
| (Increment, "arroyo.consumer.pause"), | |||
There was a problem hiding this comment.
random thought: i think this test is kind of bs and annoying when i just want to add a metric, but at teh same time it's somewhat interesting to see that we apply backpressure when a consumer is shutting down
lynnagara
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the linked incident we think that the ingest consumer
paused/resumed in very quick succession. We currently don't have any
metrics for that.