add consumer_member_id tag to partitions assign / revoked metrics #358
Conversation
| @@ -235,7 +235,7 @@ def on_partitions_assigned(partitions: Mapping[Partition, int]) -> None: | |||
| logger.info("New partitions assigned: %r", partitions) | |||
| logger.info("Member id: %r", self.__consumer.member_id) | |||
| self.__metrics_buffer.metrics.increment( | |||
| "arroyo.consumer.partitions_assigned.count", len(partitions) | |||
| "arroyo.consumer.partitions_assigned.count", len(partitions), tags={"consumer_member_id": self.__consumer.member_id} | |||
There was a problem hiding this comment.
I think member id is a method, not a property. (thus member_id() )
There was a problem hiding this comment.
I was copying what was in the log line above, is that wrong?
logger.info("Member id: %r", self.__consumer.member_id)
There was a problem hiding this comment.
looks like member_id is a string, and it's a Kafka native property
There was a problem hiding this comment.
What kind of string? :D
There was a problem hiding this comment.
Or is the point that it's not an int?
There was a problem hiding this comment.
i found it! it's uuid
In the current consumer protocol, the field member.idis assigned by broker to track group member status. A new consumer joins the group withmember.id field set as UNKNOWN_MEMBER_ID (empty string), since it needs to receive the identity assignment from broker first. For request with unknown member id, broker will blindly accept the new join group request, store the member metadata and return a UUID to consumer.
|
Wouldn't this need to be applied to the rust version as well? |
|
Yes - my immediate concern was with a Python consumer so this is where I started. |
Attempted fix for #357
DACI
Starting with the metrics most important for understanding consumer balancing across a group, but it may make sense to include this tag on other consumer-related metrics as well. Can be done in a follow up.
Questions
nullornonetag?