feat(consumer): Wrap consumer strategy with DLQ if it exists #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me though I think it should get a look from somebody who's more arroyo-familiar |
MeredithAnya
reviewed
Apr 6, 2022
|
|
||
| The `dead_letter_queue_policy` defines what to do when an bad message | ||
| is encountered throughout the next processing step(s). A DLQ wraps the | ||
| entire strategy and handles a specific exception to handle bad messages. |
There was a problem hiding this comment.
I feel like the second sentence is a little confusing to me, would it be fair to say something like?:
A DLQ policy wraps the entire strategy, catching InvalidMessage exceptions and handling them as the policy dictates.
fpacifici
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConsumerStrategyFactorybuilds the main strategy used by all consumers in SnubaHere's an example of how this will be used:
getsentry/snuba#2585