Load correct stack memory if thread record is wrong #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuhiko
requested changes
May 21, 2019
jan-auer
force-pushed
the
fix/stupid-unreal-minidumps-have-stupid-thread-memory
branch
from
d35425f
to
cf6e825
Compare
|
Updated. |
mitsuhiko
approved these changes
May 21, 2019
jan-auer
deleted the
fix/stupid-unreal-minidumps-have-stupid-thread-memory
branch
jan-auer
added a commit
that referenced
this pull request
May 21, 2019
Some minidumps contain invalid thread memory descriptors pointing to memory regions other than the ones referred to by the RSP. This is the case in UE4, for example. This causes the stackwalker to terminate early as it cannot load the actual stack memory. Other Minidump processors such as WinDbg or the Visual Studio debugger can still process such minidumps correctly. They do not load the stack memory region based on the information obtained from the TEB and instead just follow the stack walker. This patch adds the same behavior to the minidump processor. If the thread memory region does not cover the stack pointer, the region is replaced with the one covering it, if any.
jan-auer
added a commit
to getsentry/symbolic
that referenced
this pull request
May 21, 2019
Updates the breakpad processor. Apart from a newer upstream revision this includes the fix from getsentry/breakpad#1 which should allow to process UE4 minidumps correctly.
flub
pushed a commit
that referenced
this pull request
Oct 6, 2020
Some minidumps contain invalid thread memory descriptors pointing to memory regions other than the ones referred to by the RSP. This is the case in UE4, for example. This causes the stackwalker to terminate early as it cannot load the actual stack memory. Other Minidump processors such as WinDbg or the Visual Studio debugger can still process such minidumps correctly. They do not load the stack memory region based on the information obtained from the TEB and instead just follow the stack walker. This patch adds the same behavior to the minidump processor. If the thread memory region does not cover the stack pointer, the region is replaced with the one covering it, if any.
jan-auer
added a commit
that referenced
this pull request
Oct 19, 2020
Some minidumps contain invalid thread memory descriptors pointing to memory regions other than the ones referred to by the RSP. This is the case in UE4, for example. This causes the stackwalker to terminate early as it cannot load the actual stack memory. Other Minidump processors such as WinDbg or the Visual Studio debugger can still process such minidumps correctly. They do not load the stack memory region based on the information obtained from the TEB and instead just follow the stack walker. This patch adds the same behavior to the minidump processor. If the thread memory region does not cover the stack pointer, the region is replaced with the one covering it, if any.
Jake-Shadle
referenced
this pull request
in EmbarkStudios/breakpad
Aug 28, 2021
Some minidumps contain invalid thread memory descriptors pointing to memory regions other than the ones referred to by the RSP. This is the case in UE4, for example. This causes the stackwalker to terminate early as it cannot load the actual stack memory. Other Minidump processors such as WinDbg or the Visual Studio debugger can still process such minidumps correctly. They do not load the stack memory region based on the information obtained from the TEB and instead just follow the stack walker. This patch adds the same behavior to the minidump processor. If the thread memory region does not cover the stack pointer, the region is replaced with the one covering it, if any.
jubalh
pushed a commit
to jubalh/breakpad
that referenced
this pull request
Nov 10, 2021
Some minidumps contain invalid thread memory descriptors pointing to memory regions other than the ones referred to by the RSP. This is the case in UE4, for example. This causes the stackwalker to terminate early as it cannot load the actual stack memory. Other Minidump processors such as WinDbg or the Visual Studio debugger can still process such minidumps correctly. They do not load the stack memory region based on the information obtained from the TEB and instead just follow the stack walker. This patch adds the same behavior to the minidump processor. If the thread memory region does not cover the stack pointer, the region is replaced with the one covering it, if any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minidumps contain invalid thread memory descriptors pointing to memory regions other than the ones referred to by the RSP. This is the case in UE4, for example. This causes the stackwalker to terminate early as it cannot load the actual stack memory.
Other Minidump processors such as WinDbg or the Visual Studio debugger can still process such minidumps correctly. They do not load the stack memory region based on the information obtained from the TEB and instead just follow the stack walker.
This patch adds the same behavior to the minidump processor. If the thread memory region does not cover the stack pointer, the region is replaced with the one covering it, if any.