New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: further dependency use/export cleanup #106

Merged

supervacuus merged 1 commit into getsentry from fix/further_cmake_deps_cleanup

Jun 24, 2024

Collaborator

supervacuus commented Jun 19, 2024

Replace checks for _FOUND variables with checks to actual targets before we find_package() in our build scripts.
Ensure that we include the crashpad targets in the export configuration after all invocations of find_dependency()
Remove REQUIRED from the find_dependency() invocations and let it retrieve the value from the find_package() invocations in the build scripts.


          fix: further dependency use/export cleanup

4751fa2

supervacuus requested a review from a team as a code owner

June 19, 2024 15:46

supervacuus mentioned this pull request

fix: further dependency export cleanup getsentry/sentry-native#1013

Merged

1 task

supervacuus requested review from Swatinem and markushi

June 20, 2024 07:28

Swatinem approved these changes

View reviewed changes

supervacuus merged commit 11b9eaf into getsentry

7 checks passed

supervacuus deleted the fix/further_cmake_deps_cleanup branch

June 24, 2024 09:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment