Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Epic's "Easy Anti Cheat" #99

Merged

Conversation

kristjanvalur
Copy link

@kristjanvalur kristjanvalur commented Apr 3, 2024

See issue #975

Two changes are made, for the Windows platform:

  • The target process is opened with limited permissions, and only upgraded to full permission when required. When an anti-cheat watchdog is present, the target process is often protected until it crashes.
  • The target thread may be already suspended by the watchdog process. Accept a failure to suspend the target thread.

@kristjanvalur kristjanvalur requested a review from a team April 3, 2024 13:20
@bitsandfoxes
Copy link

Thanks for contributing!

@supervacuus
Copy link
Collaborator

I also tested this with the WER module and saw no regressions. Thanks!

@supervacuus supervacuus merged commit 96e301b into getsentry:getsentry Apr 15, 2024
4 checks passed
@kristjanvalur kristjanvalur deleted the kristjan/EasyAntiCheat branch April 15, 2024 09:16
@p0358
Copy link

p0358 commented May 29, 2024

If your crash dumper also meets the requirements, then setting the executable’s file name to anything that begins with “CrashReport” will allow it to operate in the same way.

So there was no need to do that step to get it working? (from EAC's dev docs) Or perhaps it also recognizes crashpad_handler.exe as supported name? I'm considering implementing EAC at some point, so I'm a bit curious about that...

@supervacuus
Copy link
Collaborator

supervacuus commented May 29, 2024

So there was no need to do that step to get it working?

I did not read it this way. To me, it reads like you need the changes in this PR and must change the name of the executable. However, you can provide the actual name of the crashpad_handler via options in the Native SDK.

Maybe @kristjanvalur can chime in.

@kristjanvalur
Copy link
Author

Im not sure what it means for EAC to know the name of your crash dumper.
In our experience, even declaring that to eac didn't help.
It was on advice from epic that the crash reporter should only request limited access to the process regardless, and then upgrade it on demand. Requesting full access on startup would fail.

@supervacuus
Copy link
Collaborator

Thanks, @kristjanvalur. I think the question is whether the code changes in crashpad are enough or if a name change of the crashpad_handler is also required. Did you do both, or did the changes to the code suffice?

@kristjanvalur
Copy link
Author

kristjanvalur commented Jun 2, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants