Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction back to DSC specification #635

Merged
merged 5 commits into from Jul 8, 2022

Conversation

lforst
Copy link
Member

@lforst lforst commented Jul 8, 2022

Resolves #634

@lforst lforst requested review from Lms24 and AbhiPrasad July 8, 2022 10:11
@lforst lforst self-assigned this Jul 8, 2022
@vercel
Copy link

vercel bot commented Jul 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
develop ✅ Ready (Inspect) Visit Preview Jul 8, 2022 at 0:57AM (UTC)

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good general description for "good quality" transaction names.

Wondering if the dependence for transaction being added to the DSC on the transaction source should be a hard requirement instead of a suggestion. But as long as Relay doesn't make sampling decisions based on the source (which IIRC and according to the spec) I think we can leave this open to SDK implementors.

src/docs/sdk/performance/dynamic-sampling-context.mdx Outdated Show resolved Hide resolved
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@lforst
Copy link
Member Author

lforst commented Jul 8, 2022

Wondering if the dependence for transaction being added to the DSC on the transaction source should be a hard requirement instead of a suggestion. But as long as Relay doesn't make sampling decisions based on the source (which IIRC and according to the spec) I think we can leave this open to SDK implementors.

Good input!

The reason I wrote it like this and also didn't make it a hard-requirement to have the transaction on the DSC based on transaction source, is because not all SDKs have the problem of "low quality transaction names" like the JS SDK with URLs and additionally not all SDKs will have to provide a transaction source until relay makes it required.
In my head, transaction source and inclusion of TXs on DSC are two different concepts, but the one can support the decision making of the other one.

@Lms24
Copy link
Member

Lms24 commented Jul 8, 2022

Yeah, makes sense to leave it as is for now

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
lforst and others added 2 commits July 8, 2022 14:54
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
@lforst lforst merged commit f005182 into master Jul 8, 2022
@lforst lforst deleted the lforst-dsc-transaction-name-quality branch July 8, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Including transaction field in Dynamic Sampling Context must depend on transaction source
5 participants