-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ui.ttid to span operations #776
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@AbhiPrasad @marandaneto @philipphofmann |
@@ -181,6 +181,7 @@ Serverless related spans are expected to follow OpenTelemetry's [Function as a S | |||
| | app.start.cold | | | |||
| ui | | An operation on a mobile UI | | |||
| | ui.load | | | |||
| | ui.ttid | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should that be part of app.start
? or every screen would have its own ttid
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
every screen it's going to have its own ttid
we'll also add the ttfd
(time to full display) to every screen, too, but that's for another pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should mention what ttid stands for = time to initial display. Maybe we could also call it
ui.load.inital
ui.load.full
? Most developers won't understand what ttid stands for and they have to go to our docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be even ui.load.initial_draw
and ui.load.full_draw
. But I agree ttid
is probably not well-known, so I'd also vote for changing it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be semantically wrong I guess, initial_draw
would mean it's drawn but that refers only to the very first frame only.
full_draw
would mean it's fully drawn, but it's not only about drawing but rather waiting for async content and redrawing it.
so maybe initial_display
and full_dislay
? it's pretty much the wording for both acronyms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so let's go with ui.load.initial_display
and ui.load.full_display
? These make sense to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philipphofmann does it make sense to you on ios?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that makes sense. I'm happier now with this name as it's self-explanatory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the operation makes sense to me
@stefanosiano, please also add |
In this same pr? Shouldn't we wait after implementing it? |
I think it's OK to merge it already, even if we don't have the implementation. We have already decided on the name. We can always change the docs again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We are going to add a ttid (time to initial display) span to the automatic activity transactions.
The use case is mainly for mobile developers.
The current activity transaction duration is not reliable to have an understanding of how much time it took to actually load an activity, due to possible other spans added during the transaction.