Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Source Map Images to Debug Meta Interface #836

Merged
merged 6 commits into from
Feb 14, 2023
Merged

Conversation

lforst
Copy link
Member

@lforst lforst commented Feb 13, 2023

Ref: https://www.notion.so/sentry/Debug-IDs-for-Source-Maps-Brainstorming-66601f1cd5f646a399f9b46fa0dfa3a5
Ref: getsentry/team-webplatform-meta#17

This PR adds a new image type to the Debug Meta interface. The new sourcemap image type will be used to map filenames of JavaScript resources to a particular source map / source file on Sentry via a debug_id.

I am not really opinionated about what the fields should be called exactly so if you have suggestions lmk.

@vercel
Copy link

vercel bot commented Feb 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
develop ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 14, 2023 at 9:20AM (UTC)

@lforst
Copy link
Member Author

lforst commented Feb 13, 2023

Maybe source_filename is not a good name. Idk what else to call it though. source_abs_path?

@lforst lforst merged commit 97b09ca into master Feb 14, 2023
@lforst lforst deleted the lforst-sourcemap-images branch February 14, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants