fix: Migrations script #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertdeng123
commented
Jun 18, 2024
| service_account_email: ${{ secrets.GOOGLE_SERVICE_ACCOUNT_EMAIL }} | ||
| service_account_key: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS }} | ||
| export_default_credentials: true | ||
| - id: 'auth' |
There was a problem hiding this comment.
switching over to using identity provider as done in ci.yml
eng-pipes/.github/workflows/ci.yml
Line 125 in 04f8a2a
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #800 +/- ##
==========================================
- Coverage 86.24% 85.05% -1.20%
==========================================
Files 117 117
Lines 3316 3372 +56
Branches 667 675 +8
==========================================
+ Hits 2860 2868 +8
- Misses 442 490 +48
Partials 14 14 ☔ View full report in Codecov by Sentry. |
hubertdeng123
had a problem deploying
to
migration
GitHub Actions
Failure
hubertdeng123
force-pushed
the
hubertdeng123/fix-migrations
branch
from
5c11e21
to
1b1acef
Compare
hubertdeng123
had a problem deploying
to
migration
GitHub Actions
Failure
IanWoodard
approved these changes
Jun 25, 2024
| @@ -34,13 +37,15 @@ jobs: | |||
| with: | |||
| node-version: '12' | |||
There was a problem hiding this comment.
We should probably update this to use node 20, which may require updating the rest of the actions in this file, but will help us ensure we are on the latest, most secure, version. This can be done in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this service account no longer exists. We've been using workload identity provider since #633 but we forgot to account for migrations.
https://github.com/getsentry/eng-pipes/actions/runs/9573265261/job/26394333363