This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
feat(doc): Add index & filename guides #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Jul 2, 2020
Co-authored-by: Mark Story <mark@sentry.io>
Co-authored-by: Mark Story <mark@sentry.io>
Co-authored-by: Mark Story <mark@sentry.io>
Co-authored-by: Mark Story <mark@sentry.io>
Co-authored-by: Mark Story <mark@sentry.io>
|
I just noticed which repository this is in. Should we also have these changes in getsentry/develop as well? I thought that repository was the 'new place' for internal/external development docs. |
|
Sure I will move the new guidelines to the new repository :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the outcome of the last TSC meeting (https://www.notion.so/sentry/93d1ddb057af4a4db67c9b741c5ab495?v=e97ab611c4b54951a6ca3e10e13be16e&p=99c691667f724ad080cb958103a36d54), I am updating this handbook by adding a section on using the index file in a component folder.
This PR also adds best practices when naming a file.