Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(frontend|backend): Enable local docker dev #69

Merged
merged 4 commits into from May 15, 2023
Merged

Conversation

cleptric
Copy link
Member

First update towards a better Docker setup.

The php-local stage contains no code and is instead synced via docker-compose.
I moved some things around and reduced the creation of layers.

@cleptric cleptric requested a review from phacops May 15, 2023 21:26
@cleptric cleptric marked this pull request as draft May 15, 2023 21:29
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1e839ff) 35.50% compared to head (cc7bb99) 35.50%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #69   +/-   ##
=========================================
  Coverage     35.50%   35.50%           
  Complexity      242      242           
=========================================
  Files            48       48           
  Lines          1963     1963           
=========================================
  Hits            697      697           
  Misses         1266     1266           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cleptric cleptric marked this pull request as ready for review May 15, 2023 21:50
docker/backend/Dockerfile Outdated Show resolved Hide resolved
cleptric and others added 2 commits May 16, 2023 00:01
@cleptric cleptric merged commit 719e7e2 into main May 15, 2023
6 checks passed
@cleptric cleptric deleted the docker-stages branch May 15, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants