Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(frontend|backend): Clean up env vars #70

Merged
merged 3 commits into from
May 16, 2023
Merged

ref(frontend|backend): Clean up env vars #70

merged 3 commits into from
May 16, 2023

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented May 15, 2023

APP_NAME is obsolete.

DEBUG defaults to false.

APP_ENCODING, APP_DEFAULT_LOCALE and APP_DEFAULT_TIMEZONE have defaults set, no need to overwrite.

@cleptric cleptric requested a review from phacops May 15, 2023 22:06
config/app.php Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4b812ef) 35.50% compared to head (959ab31) 35.50%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #70   +/-   ##
=========================================
  Coverage     35.50%   35.50%           
  Complexity      242      242           
=========================================
  Files            48       48           
  Lines          1963     1963           
=========================================
  Hits            697      697           
  Misses         1266     1266           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cleptric cleptric merged commit 8430ce3 into main May 16, 2023
6 checks passed
@cleptric cleptric deleted the clean-env branch May 16, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants