Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): Add missing NULLS LAST to weekly report query #74

Merged
merged 1 commit into from
May 19, 2023

Conversation

cleptric
Copy link
Member

No description provided.

@cleptric cleptric requested a review from phacops May 19, 2023 23:23
@cleptric cleptric added the bug label May 19, 2023
Copy link
Member

@mwarkentin mwarkentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't know what NULLS LAST does though.. just an ordering thing?

@phacops
Copy link
Contributor

phacops commented May 19, 2023

@mwarkentin it puts null values last instead of first by default in pgsql.

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a40085a) 35.50% compared to head (3b2717d) 35.50%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #74   +/-   ##
=========================================
  Coverage     35.50%   35.50%           
  Complexity      242      242           
=========================================
  Files            48       48           
  Lines          1963     1963           
=========================================
  Hits            697      697           
  Misses         1266     1266           
Impacted Files Coverage Δ
src/Command/WeeklyReportCommand.php 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cleptric cleptric merged commit 1eef4be into main May 19, 2023
5 of 6 checks passed
@cleptric cleptric deleted the fix-weekly-update branch May 19, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants