Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(potal): Do not sample slackbot messages #84

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Conversation

cleptric
Copy link
Member

The Slackbot user has an empty BotID but is instead identified by its UserID of USLACKBOT. Ignore messages sent by it.

https://twitter.com/SlackAPI/status/938378388871499776?s=20

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b2815b8) 35.48% compared to head (94b8f33) 35.48%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #84   +/-   ##
=========================================
  Coverage     35.48%   35.48%           
  Complexity      242      242           
=========================================
  Files            48       48           
  Lines          1964     1964           
=========================================
  Hits            697      697           
  Misses         1267     1267           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super michi 👏 👏 👏

@cleptric cleptric merged commit 08b8451 into main Jun 23, 2023
6 checks passed
@cleptric cleptric deleted the ignore-slackbot branch June 23, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants