Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(clickhouse): add 23.8.11.29 #22

Merged
merged 2 commits into from
May 29, 2024
Merged

ref(clickhouse): add 23.8.11.29 #22

merged 2 commits into from
May 29, 2024

Conversation

MeredithAnya
Copy link
Member

23.8.11.29 is the added as the latest in altinity's stable builds so lets use that instead of 23.8.8.21. I'll remove 23.8.8.21 once it's not used in CI.

Additionally 23.8.11.29 is already what we use in self-hosted.

@MeredithAnya MeredithAnya requested review from a team and asottile-sentry May 29, 2024 20:41
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@joshuarli joshuarli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind updating sentry dev as well?

src/sentry/conf/server.py
2888:                "ghcr.io/getsentry/image-mirror-altinity-clickhouse-server:22.8.15.25.altinitystable"

@MeredithAnya
Copy link
Member Author

MeredithAnya commented May 29, 2024

Mind updating sentry dev as well?

src/sentry/conf/server.py
2888:                "ghcr.io/getsentry/image-mirror-altinity-clickhouse-server:22.8.15.25.altinitystable"

We are still moving clusters over to newer clickhouse versions - the 23.3 upgrade should be fully completed next week. So was going to wait until that was completed to change devserver to 23.3.

The reason being I was concerned about folks introducing code that works on 23.3 but doesn't work for 22.8 , however I recognize the inverse could be true, we could be adding code that works in 22.8 but doesn't work in our now upgrade 23.3 clusters - @joshuarli do you have thoughts on this either way? In general my goal was to avoid folks trying to deploy new clickhouse features before all the clusters were moved over

(in snuba we run tests against multiple versions, but idk if it's possible to do the same in sentry)

@MeredithAnya MeredithAnya merged commit 2ab4765 into main May 29, 2024
3 checks passed
@MeredithAnya MeredithAnya deleted the meredith/new-23_8 branch May 29, 2024 21:22
@joshuarli
Copy link
Member

Mind updating sentry dev as well?

src/sentry/conf/server.py
2888:                "ghcr.io/getsentry/image-mirror-altinity-clickhouse-server:22.8.15.25.altinitystable"

We are still moving clusters over to newer clickhouse versions - the 23.3 upgrade should be fully completed next week. So was going to wait until that was completed to change devserver to 23.3.

The reason being I was concerned about folks introducing code that works on 23.3 but doesn't work for 22.8 , however I recognize the inverse could be true, we could be adding code that works in 22.8 but doesn't work in our now upgrade 23.3 clusters - @joshuarli do you have thoughts on this either way? In general my goal was to avoid folks trying to deploy new clickhouse features before all the clusters were moved over

(in snuba we run tests against multiple versions, but idk if it's possible to do the same in sentry)

ah i see, devservices should just try to follow what's in prod but prefer the lower version if it's mixed like this, so let's wait as you said

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants